Skip to content

Add support for running profiles from Add tab menu as admin without a keyboard - #15679

Merged
Mike Griese (zadjii-msft) merged 2 commits into
microsoft:mainfrom
jamespack:upstream-14517
Jul 20, 2023
Merged

Mike Griese (zadjii-msft) merged 2 commits into
microsoft:mainfrom
jamespack:upstream-14517

Conversation

@jamespack

@jamespack James Pack (jamespack) commented Jul 8, 2023 •

Copy link
Copy Markdown
Contributor

Summary of the Pull Request

Add support for running profiles in the Add Tab drop down as administrator without a keyboard.

References and Relevant Issues

#14517

Detailed Description of the Pull Request / Additional comments

This pull request adds a FlyoutMenu to each Profile entry in the Add New tab drop down. When a profile is right clicked or held for 2 seconds in the case of no mouse input will present a MenuItem to allow the user to click and run the selected profile as administrator

Validation Steps Performed

  • Responds to pointer input events (mouse, pointer, touchpad)
  • Adjusts to theme changes.
  • Only shows when a profile is selected. Will not show on settings or pallete entries

PR Checklist

…pdown which when clicked will run the selected profile as administrator
@microsoft-github-policy-service microsoft-github-policy-service Bot added Issue-Task It's a feature request, but it doesn't really need a major design. Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. labels Jul 8, 2023

@zadjii-msft Mike Griese (zadjii-msft) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good to me. Thanks!

@microsoft-github-policy-service microsoft-github-policy-service Bot removed the Needs-Second It's a PR that needs another sign-off label Jul 19, 2023
@zadjii-msft
Mike Griese (zadjii-msft) merged commit 42e9ddc into microsoft:main Jul 20, 2023
Dustin L. Howett (DHowett) pushed a commit that referenced this pull request Sep 22, 2023
… keyboard (#15679)

Add support for running profiles in the Add Tab drop down as
administrator without a keyboard.
This pull request adds a FlyoutMenu to each Profile entry in the Add New
tab drop down. When a profile is right clicked or held for 2 seconds in
the case of no mouse input will present a MenuItem to allow the user to
click and run the selected profile as administrator
- Responds to pointer input events (mouse, pointer, touchpad)
- Adjusts to theme changes.
- Only shows when a profile is selected. Will not show on settings or
pallete entries

- [x] Closes #14517
- [ ] Tests added/passed
- [ ] Documentation updated
- If checked, please file a pull request on [our docs
repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx
- [ ] Schema updated (if necessary)

(cherry picked from commit 42e9ddc)
Service-Card-Id: 90068191
Service-Version: 1.18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

Launch elevated Terminal profile without a keyboard

3 participants